Fix for C++ Recorder failure on stop() -> record() due to reusing the bag name #2224
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaelOrlov
changed the title
MichaelOrlov
requested review from
christophebedard,
emersonknapp and
fujitatomoya
MichaelOrlov
changed the title
Signed-off-by: Michael Orlov <[email protected]>
Note: if provided optional parameter uri, it will override the storage_options.uri provided during construction. Signed-off-by: Michael Orlov <[email protected]>
MichaelOrlov
force-pushed
the
morlov/bugfix-for-recorder-start-stop-start-again
branch
from
d19b762 to
320edba
Compare
Contributor
Author
|
@christophebedard @fujitatomoya @emersonknapp A friendly ping for review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses the C++ Recorder failure on stop() -> record() due to reusing the bag name.
Is this user-facing behavior change?
Yes.
uriparameter for theRecorder::record()API. If provided, it will override thestorage_options.uriprovided during construction.storage_options.urialready exists at the time when callingRecorder::record()the recorder will try to derive an alternative name by adding(n)prefix. i.e.storage_options.uri + "(n)". Wherenwill be tried from1to thestd::numeric_limits<size_t>::max().Did you use Generative AI?
Yes, I am using GitHub Copilot, GPT-5 to help with Doxygen comments and tests.
Additional Information
Potentially can be backported